fix #593 share logic between FileSystemProvider and FileSearchProvider #661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and FileSearchProvider
gjsjohnmurray
requested changes
Jun 18, 2021
gjsjohnmurray
previously approved these changes
Jun 21, 2021
|
@LogMull please resolve the conflict in |
|
@gjsjohnmurray I've resolved the conflict. I also noticed that a change from #623 was not accounted for in the new util file, so I have update it accordingly as well. |
gjsjohnmurray
requested review from
gjsjohnmurray
and removed request for
daimor
gjsjohnmurray
approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #593. The FileSystemProvider and FileSearchProvider share code that handles interfacing with the StudioOpenDialog query. This allows the Quick Open to respect the 'filter' query parameter. This has also resulted in the Quick Open returning results significantly more quickly.