Display AfterUserAction errors and remove undo on successful checkout #725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isc-bsaviano
approved these changes
Jul 22, 2021
@ty-d Does this mean that if the checkout operation intentionally changed the file (e.g. because the namespace didn't already have the "latest" version), then the developer will continue to work on an outdated version? |
|
If the user chooses to checkout the file then no undo commands will be done (unless the file was not checked out successfully). So if checkout updates the file it should not undo that update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #701, #703
Errors reported by AfterUserAction were previously ignored, now they are displayed in the output window.
When checking out a file your edit was always undone. Now it only undoes the edit if the user selects "No" or "Cancel" or if an error is reported when trying to check out the file.