-
Notifications
You must be signed in to change notification settings - Fork 48
package updates #740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package updates #740
Conversation
@daimor can you look at these failures? I don't know why these linting issues should be stopping the checks. |
f1a3c6f
to
c7eb38e
Compare
There are some issues with dependencies, node-fetch requires newer version of typescript 4.* instead of current 3.*. And this cause to cascade of upgrades for related packages, such as linting and testing, I'll check and update the PR, later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK but I didn't do any testing.
@daimor linting errors with prettier again. |
I'll check, looks like some of the linting-related packages updated checks for linter. |
Thanks @daimor. After @gjsjohnmurray reviews I will merge. |
Or did we say the only meaningful way to test these changes is to use them? |
Merge, get beta version and users will check it |
This PR fixes #