Skip to content

package updates #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 6, 2021
Merged

package updates #740

merged 7 commits into from
Oct 6, 2021

Conversation

isc-rsingh
Copy link
Member

This PR fixes #

@isc-rsingh
Copy link
Member Author

@daimor can you look at these failures? I don't know why these linting issues should be stopping the checks.

@isc-rsingh isc-rsingh requested a review from daimor September 28, 2021 13:37
@daimor
Copy link
Member

daimor commented Sep 28, 2021

There are some issues with dependencies, node-fetch requires newer version of typescript 4.* instead of current 3.*. And this cause to cascade of upgrades for related packages, such as linting and testing, I'll check and update the PR, later.

gjsjohnmurray
gjsjohnmurray previously approved these changes Sep 30, 2021
Copy link
Contributor

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK but I didn't do any testing.

@isc-rsingh
Copy link
Member Author

@daimor linting errors with prettier again.

@daimor
Copy link
Member

daimor commented Oct 1, 2021

I'll check, looks like some of the linting-related packages updated checks for linter.

@daimor daimor marked this pull request as ready for review October 5, 2021 08:04
@isc-rsingh
Copy link
Member Author

Thanks @daimor. After @gjsjohnmurray reviews I will merge.

@isc-rsingh
Copy link
Member Author

Or did we say the only meaningful way to test these changes is to use them?

@daimor
Copy link
Member

daimor commented Oct 5, 2021

Merge, get beta version and users will check it

@isc-rsingh isc-rsingh merged commit 2ef5cc0 into master Oct 6, 2021
@isc-rsingh isc-rsingh deleted the dependabot-fixes branch October 6, 2021 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants