Allow Server Command menu to open a URL in an external browser #755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow Server Command Menu to open a URL in an external browser
|
I'm a fan of this - we had the same level of support in Atelier as well. |
gjsjohnmurray
approved these changes
Oct 25, 2021
|
@a-boertien Thanks for the PR! Much appreciated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows a server command menu to open a URL in the user's default browser (externally to VSCode, rather than a VSCode web view).
Previously, a server command menu with an Action==3 was not supported at all.
With this change, a server command menu with an Action==3 and a Target that is a URL will open in the user's default browser - which is the same functionality that was previously supported in IRIS Studio.