Skip to content

Fix FileSystemProvider mtime caching #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2021

Conversation

isc-bsaviano
Copy link
Contributor

This PR fixes FileSystemProvider mtime caching. Previously, the cache would get constantly overwritten so calls to GET /doc wouldn't include the IF_NONE_MATCH header, forcing the server to send the full contents of the file back every time. This fix corrects this problem so the proper mtime is sent with GET /doc requests.

Copy link
Contributor

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on code-reading this looks OK to me. I haven't tested the dev VSIX though.

@isc-bsaviano
Copy link
Contributor Author

@gjsjohnmurray @daimor There's something wrong with the CI. Compile fails because it can't find the vscode module. I'm not going to merge this until we get a CI run for this PR that succeeds

@daimor
Copy link
Member

daimor commented Nov 12, 2021

There is something wrong with downloading vscode.proposed.d.ts

@daimor
Copy link
Member

daimor commented Nov 12, 2021

microsoft/vscode#136964

@gjsjohnmurray
Copy link
Contributor

microsoft/vscode#136964

Correct. The CI needs to be revised to handle the relocation of vscode.d.ts and the breaking up of vscode.proposed.d.ts.

But I think the reason this is suddenly biting us is that the CI downloads these from main (actually, still using the old name 'master'). It should probably be using npx instead.

@daimor
Copy link
Member

daimor commented Nov 12, 2021

I'll take care of this change, and create a PR for it

@isc-bsaviano
Copy link
Contributor Author

@gjsjohnmurray We have a dev vsix for this now if you want to test it before I merge

@gjsjohnmurray
Copy link
Contributor

A quick test of the dev vsix didn't find anything broken, so I'm happy for my approval to stand.

@isc-bsaviano isc-bsaviano merged commit 84b2a99 into intersystems-community:master Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants