Overhaul WorkspaceSymbolProvider
#772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Search for all class members, not just methods. - Don't search for Studio documents so we avoid duplication functionality that's covered by the `FileSearchProvider` (Quick Open). - Properly translate `query` to a `%MATCHES` compatible pattern while following the interpretation guidelines. - Use the same `SymbolKind` as the Language Server for all class member types for consistency. - Use the `vscode.executeDocumentSymbolProvider` command to find the location of the symbol. - Improve performance by only computing symbol location when selected by the user. - Remove unneeded setting `"objectscript.searchAllDocTypes"`.
daimor
requested changes
Nov 17, 2021
daimor
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileSearchProvider(Quick Open).queryto a%MATCHEScompatible pattern while following the interpretation guidelines.SymbolKindas the Language Server for all class member types for consistency.vscode.executeDocumentSymbolProvidercommand to find the location of the symbol."objectscript.searchAllDocTypes".