Improve client-side DFI workflow #808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@daimor @gjsjohnmurray How does this look? |
gjsjohnmurray
approved these changes
Jan 6, 2022
There was a problem hiding this comment.
Looks OK to me but @daimor is a much bigger user of client-side mode. And it's rare that I work with DFIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #35 and fixes #313
Previously, DFI files could only be edited and synced to the server using server-side editing by adding
?filter=*.dfito anisfsfolder URI. This PR adds support for client-side editing of DFI files.Changes made:
dfiinstead ofothwhenobjectscript.export.addCategoryistrue.objectscript.export.atelieristrue.objectscript.export.addCategoryistrue, the files must be in thedfifolder).