Fix proposed API registration #814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@gjsjohnmurray Nope, just tested without them and everything still works. I will remove them. |
daimor
approved these changes
Dec 27, 2021
|
With this change does the argv json setting really become redundant, as Gabriel's comment on the issue implies? I am away from my desk so unable to test. |
|
@gjsjohnmurray There's more context to what he is saying. The issue we ran into is that activation failed when the argv setting wasn't present, when the expected behavior is that all non-proposed features would be enabled and the extension would activate successfully. We still expect that the argv setting is required to use the proposed APIs, but we expect that with this PR it won't be required to activate a beta or dev vsix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where beta and dev vsix's cannot be activated with proposed APIs disabled.
See #781, starting from #781 (comment) for how this issue manifests.