Skip to content

Provide WorkspaceSymbols for all servers in workspace #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2022
Merged

Provide WorkspaceSymbols for all servers in workspace #815

merged 1 commit into from
Jan 10, 2022

Conversation

isc-bsaviano
Copy link
Contributor

This PR fixes #375

Changes made:

  • Loop through folders in the workspace and determine which server and namespace they’re connected to.
  • Filter out duplicate server/namespace combos to avoid querying a server multiple times for the same namespace.
  • Filter out results from system classes in non-%SYS namespaces when a workspace is connected to both the %SYS and a non-%SYS namespace for the same server to avoid duplicate results.

gjsjohnmurray
gjsjohnmurray approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I haven't tested it.

@isc-bsaviano isc-bsaviano merged commit d1c09ca into intersystems-community:master Jan 10, 2022
@isc-bsaviano isc-bsaviano deleted the fix-375 branch January 10, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjsjohnmurray gjsjohnmurray gjsjohnmurray approved these changes

@daimor daimor Awaiting requested review from daimor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi-root workspace: 'Open Symbol by Name' only searches one namespace
2 participants
@isc-bsaviano @gjsjohnmurray