Skip to content

Improve exporting #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2022
Merged

Conversation

isc-bsaviano
Copy link
Contributor

This PR fixes #129

Changes made:

  • Modify "vscode-objectscript.export" to do the following:
    • Don’t allow the user to select a virtual folder as the export destination.
    • If there are no suitable folders in the workspace, notify the user and exit.
    • Replace the call to AtelierAPI.getDocNames() with a call to the StudioOpenDialog query to improve performance and to allow the filtering out of system items when the namespace is not %SYS.
    • Ask the user for confirmation and allow them to exclude individual files from the export list before starting the export.
  • Add "vscode-objectscript.exportCurrentFile” command that exports the currently opened file, if it was opened from the ObjectScript Explorer.
  • Change RootNode.getList() query to only SELECT needed columns from StudioOpenDialog to improve performance.
  • Improve documentation for "objectscript.export.filter" setting.

Copy link
Contributor

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Various comments for consideration.

@isc-bsaviano isc-bsaviano merged commit 8e1cdc8 into intersystems-community:master Jan 10, 2022
@isc-bsaviano isc-bsaviano deleted the fix-129 branch January 10, 2022 20:21
isc-bsaviano added a commit that referenced this pull request Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need ability to export currently open artifact
2 participants