Skip to content

Merge, Pull and Rebase now don't use diff to synchronize file system with IRIS #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 27, 2024

Conversation

isc-hwojnick
Copy link
Contributor

@isc-hwojnick isc-hwojnick commented Jun 26, 2024

Merge, Pull and Rebase will now use the output of the command itself to drive their synchronization with IRIS.

ex:
the merge command will output:

Merge made by the 'ort' strategy.
cls/package/newb4.cls | 5 -----
cls/package/newb5.cls | 5 -----
cls/package/newb7.cls | 5 +++++
3 files changed, 5 insertions(+), 10 deletions(-)
delete mode 100644 cls/package/newb4.cls
delete mode 100644 cls/package/newb5.cls
create mode 100644 cls/package/newb7.cls

In this example, the last 3 lines of the output are used to sync iris with the filesystem

Copy link
Collaborator

@isc-pbarton isc-pbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge and checkout of local and remote branches are working great for me.
Pull is having the issue from before where deletes/adds on the local branch get undone - but that is preexisting behavior for as long as the pull function has been there. We could create a new issue to address that later by using the same logic as merge and checkout.
The preview pull on pull.csp is broken again and doesn't display any output. That should be fixed, I think by printing the output streams after preview in %zpkg.isc.sc.git.Socket

@isc-hwojnick
Copy link
Contributor Author

Merge and checkout of local and remote branches are working great for me. Pull is having the issue from before where deletes/adds on the local branch get undone - but that is preexisting behavior for as long as the pull function has been there. We could create a new issue to address that later by using the same logic as merge and checkout. The preview pull on pull.csp is broken again and doesn't display any output. That should be fixed, I think by printing the output streams after preview in %zpkg.isc.sc.git.Socket

@isc-pbarton I think I should just throw pull in with merge and rebase in this git issue and rename it. What do you think?

@isc-hwojnick
Copy link
Contributor Author

As for the previewing, I think I can fix that

@isc-hwojnick isc-hwojnick changed the title Merge and Rebase now don't use diff to synchronize file system with IRIS Merge, Pull and Rebase now don't use diff to synchronize file system with IRIS Jun 26, 2024
@isc-hwojnick isc-hwojnick requested a review from isc-pbarton June 26, 2024 18:44
@isc-tleavitt isc-tleavitt merged commit 61a58db into main Jun 27, 2024
2 checks passed
@isc-tleavitt isc-tleavitt deleted the merge-rebase-resolve-diff-issue branch June 27, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants