Skip to content

Add TypeScript test case and add TypeScript FAQ to doc. #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Conversation

ota-meshi
Copy link
Member

I've found that using parserOptions.parser overwrites the .json and .yaml parsers and doesn't work correctly.
I added a workaround to the document to work around this issue and added a test case to make sure this works correctly.

refs #103

@ota-meshi ota-meshi added Type: Documentation A documentation fixes Type: Testing Adding missing tests or correcting existing tests labels Aug 11, 2020
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kazupon kazupon merged commit 5281fa4 into master Aug 12, 2020
@kazupon kazupon deleted the ts-test branch August 12, 2020 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation A documentation fixes Type: Testing Adding missing tests or correcting existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants