-
-
Notifications
You must be signed in to change notification settings - Fork 1
chore: spelling and linting #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThis update corrects typographical errors in documentation comments, test names, log messages, and import statements across multiple files. It also adds explicit imports of the Node.js Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
deno/locale.ts (1)
260-263
: Typo fix in JSDoc comment
The correction from “paser” to “parser” fixes the spelling in the Unicode script subtag description. For consistency withsrc/locale.ts
, you may consider using the verb form “parse” instead of the noun “parser.”
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (13)
README.md
(1 hunks)deno/README.md
(1 hunks)deno/locale.ts
(1 hunks)deno/shared.ts
(1 hunks)deno/web.ts
(1 hunks)scripts/deno.ts
(1 hunks)src/h3.ts
(1 hunks)src/hono.ts
(1 hunks)src/locale.test-d.ts
(2 hunks)src/locale.ts
(1 hunks)src/node.ts
(2 hunks)src/shared.ts
(1 hunks)src/web.ts
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
deno/README.md
[grammar] ~156-~156: Nouns are not usually modified by plural nouns. Is it possible that you meant to use the singular or possessive form here?
Context: ...thLocale-
tryQueryLocale` The about utilities functions accept Web APIs such as [Requ...
(PLURAL_MODIFIER)
[grammar] ~160-~160: The first clause in a conditional statement is not usually in the future tense. Consider removing the modal verb “will”.
Context: ... #### Specialized environments If you will use Node.js and H3, You can do `import { .....
(CONDITIONAL_CLAUSE)
[uncategorized] ~164-~164: Loose punctuation mark.
Context: ...ENV}is one of the following: -
node: accept
IncomingMessageand
Outgoing`...
(UNLIKELY_OPENING_PUNCTUATION)
README.md
[grammar] ~156-~156: Nouns are not usually modified by plural nouns. Is it possible that you meant to use the singular or possessive form here?
Context: ...thLocale-
tryQueryLocale` The about utilities functions accept Web APIs such as [Requ...
(PLURAL_MODIFIER)
[grammar] ~160-~160: The first clause in a conditional statement is not usually in the future tense. Consider removing the modal verb “will”.
Context: ... #### Specialized environments If you will use Node.js and H3, You can do `import { .....
(CONDITIONAL_CLAUSE)
[uncategorized] ~164-~164: Loose punctuation mark.
Context: ...ENV}is one of the following: -
node: accept
IncomingMessageand
Outgoing`...
(UNLIKELY_OPENING_PUNCTUATION)
🔇 Additional comments (16)
src/hono.ts (1)
58-58
: Approve documentation typo fix.Corrected “retuns” to “returns” in the JSDoc for
getHeaderLanguage
. No functional code changes.src/web.ts (1)
57-57
: Approve documentation typo fix.Corrected “retuns” to “returns” in the JSDoc for
getHeaderLanguage
. No functional code changes.src/h3.ts (1)
57-57
: Approve documentation typo fix.Corrected “retuns” to “returns” in the JSDoc for
getHeaderLanguage
. No functional code changes.deno/web.ts (1)
57-57
: Approve documentation typo fix.Corrected “retuns” to “returns” in the JSDoc for
getHeaderLanguage
. No functional code changes.deno/shared.ts (1)
134-134
: Approve documentation typo fix.Corrected “getPathLanugage” to “getPathLanguage” in the JSDoc for
registerPathLanguageParser
. No functional code changes.src/shared.ts (1)
134-134
: Typo fix in JSDoc parameter description
Corrected the function name in the comment from "getPathLanugage" to "getPathLanguage".scripts/deno.ts (1)
29-29
: Typo fix in console log
Corrected "directries" to "directories" in the log message.deno/README.md (2)
156-156
: Typo fix in documentation
Corrected "utilies" to "utilities" in the description of supported Web API functions.🧰 Tools
🪛 LanguageTool
[grammar] ~156-~156: Nouns are not usually modified by plural nouns. Is it possible that you meant to use the singular or possessive form here?
Context: ...thLocale-
tryQueryLocale` The about utilities functions accept Web APIs such as [Requ...(PLURAL_MODIFIER)
164-164
: Typo fix in list item
Corrected "accpet" to "accept" in the node environment description.🧰 Tools
🪛 LanguageTool
[uncategorized] ~164-~164: Loose punctuation mark.
Context: ...ENV}is one of the following: -
node: accept
IncomingMessageand
Outgoing`...(UNLIKELY_OPENING_PUNCTUATION)
README.md (2)
156-156
: Typo fix in documentation
Corrected "utilies" to "utilities" in the description of supported Web API functions.🧰 Tools
🪛 LanguageTool
[grammar] ~156-~156: Nouns are not usually modified by plural nouns. Is it possible that you meant to use the singular or possessive form here?
Context: ...thLocale-
tryQueryLocale` The about utilities functions accept Web APIs such as [Requ...(PLURAL_MODIFIER)
164-164
: Typo fix in list item
Corrected "accpet" to "accept" in the node environment description.🧰 Tools
🪛 LanguageTool
[uncategorized] ~164-~164: Loose punctuation mark.
Context: ...ENV}is one of the following: -
node: accept
IncomingMessageand
Outgoing`...(UNLIKELY_OPENING_PUNCTUATION)
src/node.ts (2)
58-58
: Typo fix in JSDoc description
Corrected "retuns" to "returns" in thegetHeaderLanguage
JSDoc comment.
580-580
: Typo fix in JSDoc return description
Corrected "enmpty" to "empty" in thegetNavigatorLanguage
JSDoc comment.src/locale.ts (1)
260-263
: Typo fix in JSDoc comment
The correction from “paser” to “parse” accurately fixes the spelling in the Unicode script subtag description. No functional impact.src/locale.test-d.ts (2)
289-289
: Fix test name spelling
Updated the test suite name fromParseUnicodeLangugageId
toParseUnicodeLanguageId
. This aligns the test name with the actual type.
315-315
: Fix comment spelling
Corrected “Erros” to “Errors” in the comment header for the error cases.
Description
These utilities are great! For some reason I thought most of the utilities were in intlify/h3 🤦..
This PR contains spelling/typo fixes and resolves linting errors (automatically with
deno lint --fix
anddeno fmt
)Linked Issues
Additional context
Summary by CodeRabbit
Summary by CodeRabbit
Documentation
Style
Chores
process
module in scripts, tests, and playground files to support process-related operations and event handling.