Skip to content

feat: add conditional property to disable GraphQLController #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2019

Conversation

igdianov
Copy link
Collaborator

@igdianov igdianov commented Aug 17, 2019

This PR adds support to disable GraphQLController auto configuration using spring.graphql.jpa.query.web.enabled property. The auto configuration will also be disabled if spring.graphql.jpa.query.enabled=false

Fixes #144

@igdianov igdianov self-assigned this Aug 17, 2019
@codecov
Copy link

codecov bot commented Aug 17, 2019

Codecov Report

Merging #161 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #161   +/-   ##
=========================================
  Coverage     68.11%   68.11%           
  Complexity      498      498           
=========================================
  Files            33       33           
  Lines          2578     2578           
  Branches        431      431           
=========================================
  Hits           1756     1756           
  Misses          644      644           
  Partials        178      178
Impacted Files Coverage Δ Complexity Δ
...oconfigure/GraphQLControllerAutoConfiguration.java 100% <ø> (ø) 1 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3f7877...82a4a15. Read the comment docs.

@igdianov igdianov merged commit 4bf7596 into master Aug 17, 2019
@igdianov igdianov deleted the igdianov-web-conditional-property branch August 17, 2019 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature flag does not work
1 participant