-
Notifications
You must be signed in to change notification settings - Fork 54
Add METHOD to the @GraphQLIgnore annotation target #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add METHOD to the @GraphQLIgnore annotation target #165
Conversation
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
============================================
+ Coverage 68.11% 68.12% +0.01%
- Complexity 498 503 +5
============================================
Files 33 33
Lines 2578 2576 -2
Branches 431 431
============================================
- Hits 1756 1755 -1
Misses 644 644
+ Partials 178 177 -1
Continue to review full report at Codecov.
|
@anotender Thanks for the PR. It would be nice to have a test case for this |
…h 'get' and has no reflection in any of the class' properties
@igdianov I've just added additional test cases and a couple of code changes required to work correctly. Please have a look if it looks ok ;) |
…ng an exception when property not found
@anotender Thanks! I am traveling at the moment. I will review everything over the weekend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anotender LGTM Thank you very much for contribution.
Fixes #153 by adding METHOD to annotation target, so given
@GraphQLIgnore
annotationcan be applied on getter methods in entity class to exclude these properties from schema mapping, i.e.: