Skip to content

fix: switch off lower(COLUMN_NAME) decoration on String equality check #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2019

Conversation

igdianov
Copy link
Collaborator

Fixes #185

@igdianov igdianov self-assigned this Sep 10, 2019
@igdianov igdianov added the bug label Sep 10, 2019
@igdianov
Copy link
Collaborator Author

@MurrayFurtado here is the fix to turn off default lowercase decoration equality check for strings. Let me know if it works for you.

@codecov
Copy link

codecov bot commented Sep 11, 2019

Codecov Report

Merging #186 into master will decrease coverage by 0.1%.
The diff coverage is 42.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #186      +/-   ##
============================================
- Coverage     70.94%   70.84%   -0.11%     
  Complexity      874      874              
============================================
  Files            51       51              
  Lines          3848     3855       +7     
  Branches        661      663       +2     
============================================
+ Hits           2730     2731       +1     
- Misses          839      843       +4     
- Partials        279      281       +2
Impacted Files Coverage Δ Complexity Δ
...graphql/jpa/query/schema/impl/PredicateFilter.java 100% <100%> (ø) 5 <0> (ø) ⬇️
...hql/jpa/query/schema/impl/JpaPredicateBuilder.java 55.58% <20%> (-0.89%) 108 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2d4756...82e24d1. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 11, 2019

Codecov Report

Merging #186 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #186      +/-   ##
============================================
- Coverage     70.94%   70.92%   -0.03%     
+ Complexity      874      873       -1     
============================================
  Files            51       51              
  Lines          3848     3845       -3     
  Branches        661      660       -1     
============================================
- Hits           2730     2727       -3     
  Misses          839      839              
  Partials        279      279
Impacted Files Coverage Δ Complexity Δ
...hql/jpa/query/schema/impl/JpaPredicateBuilder.java 56.63% <100%> (+0.16%) 108 <0> (ø) ⬇️
.../graphql/jpa/query/introspection/Constructors.java 78% <0%> (-4%) 14% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2d4756...c80e32b. Read the comment docs.

@igdianov igdianov force-pushed the igdianov-fix-lower-case branch from 82e24d1 to be4e7b2 Compare September 11, 2019 03:32
@igdianov igdianov force-pushed the igdianov-fix-lower-case branch from be4e7b2 to 246988d Compare September 11, 2019 03:52
@igdianov igdianov merged commit 9445f89 into master Sep 11, 2019
@igdianov igdianov deleted the igdianov-fix-lower-case branch September 11, 2019 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it possible to switch off lower(COLUMN_NAME) decoration on String equality check
1 participant