Skip to content

Add support for IN/NIN, BETWEEN/NOT_BETWEEN predicates for floating point numbers #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2022
Merged

Add support for IN/NIN, BETWEEN/NOT_BETWEEN predicates for floating point numbers #305

merged 1 commit into from
Oct 22, 2022

Conversation

rtmkv
Copy link
Contributor

@rtmkv rtmkv commented Jun 28, 2022

  • Add array value predicate handling for floating point numbers in JpaPredicateBuilder
  • Add test entity FloatingThing
  • Add test cases to GraphQLExecutorTests

@proth1
Copy link
Contributor

proth1 commented Jun 28, 2022

  • Add array value predicate handling for floating point numbers in JpaPredicateBuilder
  • Add test entity FloathingThing
  • Add test cases to GraphQLExecutorTests

Hi @rtmkv I think you may have a typo in your comment / 2nd bullet where "FloathingThing" should be "FloatingThing"

@vporoxnenko
Copy link

@proth1 @czyba @molexx @negesti
guys, pls review somebody this pr I also want this feature

@bahurski-ivan
Copy link
Contributor

bahurski-ivan commented Jul 5, 2022

@igdianov sorry for direct tag, but is there any chance to get this merged?

@igdianov
Copy link
Collaborator

@bahurski-ivan, @rtmkv, @vporoxnenko Thank you for contribution. I can also backport it into 0.4.x maintenance branch.

@igdianov igdianov merged commit 0fba728 into introproventures:master Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants