fix: blocks may not be in the blockstore yet #215
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because some blockstore implementations batch up write before committing them to disk or wherever, they may not be available when we think they should be. I noticed this module throwing unhandledPromiseRejections around this so the change here handles missing blocks by putting the task back into the queue to process later, with a fairly arbitrary 5x limit on processing a given task.
achingbrain
force-pushed
the
fix/unhandled-promise-rejection
branch
from
98d6514 to
d77adf8
Compare
hugomrdias
approved these changes
Mar 5, 2020
|
The way this works has changed with #211, which is close to being merged. My preference would be to concentrate on getting that PR merged and then tackle this issue. |
|
I think the code can still cause |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because some blockstore implementations batch up write before committing them to disk or wherever, they may not be available when we think they should be.
I noticed this module throwing unhandledPromiseRejections around this so the change here handles missing blocks by putting the task back into the queue to process later, with a fairly arbitrary 5x limit on processing a given task.