Update pitch #1
Merged
Update pitch #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itingliu
changed the title
CustomRegexComponent - Design for added algorithms - Design for CustomRegexComponent - Add a few doc comments
- Motivation for adding algorithms
- Motivation for `CustomRegexComponent`
- Design for added algorithms
- Design for `CustomRegexComponent`
- Add a few doc comments
itingliu
force-pushed
the
pr/string-processing-pitch-update
branch
from
1abdcab to
9432324
Compare
itingliu
pushed a commit
that referenced
this pull request
Apr 22, 2022
Remove compiling argument label
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructure the pitch to this structure:
CustomRegexComponentCustomRegexComponentAdd a few doc comments