Skip to content

Enhanced parsing of XML attributes #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 24, 2024
Merged

Enhanced parsing of XML attributes #586

merged 5 commits into from
Feb 24, 2024

Conversation

javadev
Copy link
Owner

@javadev javadev commented Feb 20, 2024

No description provided.

@javadev javadev mentioned this pull request Feb 20, 2024
@javadev javadev added the bug label Feb 20, 2024
@javadev javadev added this to the v1.99 milestone Feb 20, 2024
@javadev javadev removed the bug label Feb 20, 2024
@javadev
Copy link
Owner Author

javadev commented Feb 20, 2024

What problem does this code solve?
Enhanced parsing of XML attributes

Does the code still compile with Java 11?
Yes

Risks
Low

Changes to the API?
No

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No

Was any code refactored in this commit?
Enhanced XML attribute parsing functionality

Review status
APPROVED

Starting 3-day comment window

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f1708fc) 100.00% compared to head (6db73ee) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##                main      #586   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      1522      1522           
===========================================
  Files              6         6           
  Lines           4378      4379    +1     
  Branches         811       811           
===========================================
+ Hits            4378      4379    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@javadev javadev merged commit ba51328 into main Feb 24, 2024
@javadev javadev deleted the fix-xml-to-json branch February 24, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants