Chain<T>.uniq(Function1<T, F>) should return Iterable<T>, not Iterable<F>. #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
psobot
force-pushed
the
fix-chaining-uniq-by
branch
from
8689281 to
d37791d
Compare
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
=======================================
Coverage 100% 100%
Complexity 40 40
=======================================
Files 3 3
Lines 52 52
Branches 4 4
=======================================
Hits 52 52
Continue to review full report at Codecov.
|
javadev
reviewed
Apr 2, 2017
| @SuppressWarnings("unchecked") | ||
| public void chain8() { | ||
| final List<Comparable> result = $.chain($.chain($.class.getDeclaredMethods()) | ||
| .reduce(new FunctionAccum<List<String>, Method>() { |
There was a problem hiding this comment.
Hi,
Thanks for your improvements!
It may be map() method here instead of reduce().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$.uniq(Function1<T, F>)returns anIterable<T>, by usingFas the uniqueness parameter. However, when usingChain,Chain.uniq(Function1<T, F>)returns anIterable<F>. This PR fixes that and adds a test (inChainingTest) to validate this behaviour.