Skip to content

Use strategies from SCM to the build name job #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Turiok
Copy link
Contributor

@Turiok Turiok commented Mar 24, 2023

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

close #166

Instead of using the full display name of the job. It's using the value of ChangeRequestStrategy of the MergeRequestSCMRevision object

@Turiok Turiok requested a review from jetersen as a code owner March 24, 2023 23:26
@Turiok Turiok force-pushed the bugfix/use_strategies_to_mr_build_name branch from 0beee4a to 85830c8 Compare March 24, 2023 23:30
@spidey
Copy link

spidey commented Mar 25, 2023

Nice! Looks good. A simple change will have the bug fixed.

@spidey
Copy link

spidey commented Apr 1, 2023

Repeating my comment on the issue:

Managed to reproduce the issue with publish plugin from Jenkins plugin marketplace and then the branch proposed without the issue. Tested all 3 configurations successfully: MR revision, merged result and both together.

It's ready to be merged in my opinion.

@jetersen jetersen added the bug Something isn't working label Apr 3, 2023
@jetersen jetersen merged commit 0ddadb8 into jenkinsci:master Apr 3, 2023
@Turiok Turiok deleted the bugfix/use_strategies_to_mr_build_name branch May 28, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitLab being notified of 2 builds per branch even when the discover strategy is configured as branch revision only
3 participants