Fix case where "SecretTokenAsPlainText" is null #324
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #304
Fixes #292
getSecretTokenAsPlainText()
can return null, see:https://github.com/jenkinsci/gitlab-branch-source-plugin/blob/d45c0f4c00428cd0d79ba15af87091708b4b58b8/src/main/java/io/jenkins/plugins/gitlabserverconfig/servers/GitLabServer.java#LL397C1-L407C1
So the code needs to be able to handle the
null
case.""
(sincenull
will just preserve the current value)X-Gitlab-Token
sent by GitLab in the POST request, when the header is absent, this means that theSecretToken
in Jenkins for that server is expected to be null or empty.Testing done
TODO
Submitter checklist