fix(no-large-snapshots): use a far better message for when an unexpected snapshot is found #1736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulrichstark
changed the title
G-Rath
reviewed
May 25, 2025
G-Rath
changed the title
G-Rath
approved these changes
May 25, 2025
camc314
pushed a commit
to oxc-project/oxc
that referenced
this pull request
May 25, 2025
- re-word diagnostic messages ("Disallow large snapshots." => "Snapshot
is too long.")
- fix incorrect help message
- related:
jest-community/eslint-plugin-jest#1736
- add test to include `no_snapshot` diagnostic in test snapshot
- minor other code refactorings to improve readability
|
@SimenB this failed release due to the merge queue requirement: fwiw, I'm not super worried about renovate merging PRs with a failing CI as that doesn't happen a whole lot, so feel free to just disable the merge queue for now |
4 tasks
github-actions bot
pushed a commit
that referenced
this pull request
May 27, 2025
## [28.11.1](v28.11.0...v28.11.1) (2025-05-27) ### Bug Fixes * **no-large-snapshots:** use a far better message for when an unexpected snapshot is found ([#1736](#1736)) ([0f5b873](0f5b873))
|
🎉 This PR is included in version 28.11.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The incorrect message was introduced by #278