-
Notifications
You must be signed in to change notification settings - Fork 248
[vscode-extension] reopen vscode in devbox env using process communication #1075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
75274d2
to
32b31de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
}); | ||
} | ||
// change this to absolute path to custom compiled devbox when testing | ||
const devbox = 'devbox'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this would have to be something else for prod?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LucilleH No, for testing locally on a compiled devbox this would have to point to the path to the compiled devbox.
This comment is mostly a note-to-self for future changes.
For example, if I change something in CLI and want to see how it interacts with the extension, I should change this line to /Users/mohsen/projects/devbox/dist/devbox
so that my changes in compiled devbox CLI gets used instead of the installed devbox. Hope that makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, To use a custom compiled devbox when testing, change this to an absolute path.
lol
55db3c1
to
55e10bf
Compare
8cf4d99
to
6e1d7ca
Compare
Summary
Added ability to reload a vscode window and re-open it in a devbox environment.
This is done in 4 steps:
NOTE: This required changes to both CLI and the extension, so the release of extension has to happen after CLI.
Addresses #1029
How was it tested?
vstest/
)const devbox = 'devbox';
toconst devbox = <absolute path to compiled CLI binary>
cd devbox/vscode-extension
then package an installable extensinon file:vsce package
.(this will create a devbox-version.vsix file)code --install-extension path-to-vsix-file
vstest/
in vscode.echo $foo
it should be empty. Then typewhich hello
and it should point to devbox environment's hello, or say command not found