Update nodejs examples #1087
Merged
Update nodejs examples #1087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savil
approved these changes
Jun 2, 2023
| "pnpm install", | ||
| "pnpm run start" | ||
| ] | ||
| } |
There was a problem hiding this comment.
would you mind adding a run_test devbox script?
That way, our testscripts framework will run it to ensure we don't regress this functionality.
(optional) In that, you could verify some output if you want, but even just ensuring it "runs" is a good start.
| "npm install", | ||
| "npm run build", | ||
| "npm run start" | ||
| ] |
Lagoja
approved these changes
Jun 2, 2023
LucilleH
force-pushed
the
lucille--update-nodejs
branch
from
46a480a to
94fb9f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update nodejs examples. Add pnpm example as well.
How was it tested?
devbox shell in each example