Change error message for devbox add when a package is not found #1088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucilleH
force-pushed
the
lucille--change-error-msg
branch
from
112e938 to
f4f29af
Compare
mikeland73
requested changes
Jun 2, 2023
internal/boxcli/add.go
Outdated
| @@ -37,7 +36,7 @@ func addCmd() *cobra.Command { | |||
| return nil | |||
| } | |||
| err := addCmdFunc(cmd, args, flags) | |||
| if errors.Is(err, nix.ErrPackageNotFound) { | |||
| if err != nil { | |||
There was a problem hiding this comment.
This will mask any other error (including not logging them to Sentry)
I think we should change https://github.com/jetpack-io/devbox/blob/main/internal/searcher/client.go#L63-L63 to return ErrPackageNotFound (maybe move it to searcher pkg) so we only show this error message for that error.
There's also this potential error as well: https://github.com/jetpack-io/devbox/blob/main/internal/nix/input.go#L260-L260
not sure if we need any special handling for that.
There was a problem hiding this comment.
Just checked, no need for https://github.com/jetpack-io/devbox/blob/main/internal/nix/input.go#L260-L260 as that only happens when a user does:
devbox add nodejs@
with the @ but no version
mikeland73
approved these changes
Jun 2, 2023
mikeland73
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change error message for devbox add when a package is not found. To repro:
devbox add hellow@latestOriginal output:
New output:
How was it tested?