[envrc] run devbox install to ensure createWrappers is called #1092
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our
.envrc
today callsshellenv
but that doesn't runcreateWrappers
.If the package's binary may change, then the .envrc environment will not get updated.
How was it tested?
in
examples/flakes/php
, I did:devbox generate direnv
php -m | grep ds
which printsds
.examples/flakes/php/my-php-flake/flake.nix
to removeds
extensionphp -m | grep ds
. This still printsds
.Now, for the test steps:
examples/flakes/php
)php -m | grep ds
.BEFORE: This still prints
ds
.AFTER: no
ds
is printed.Note, in Step 4, ideally we would not print
ds
but for that to happen the direnv would needto check local flake files for changes. Today, it just checks devbox.json for changes.
Not addressing in this PR (workaround:
cd
out and back in to the directory)