[devcontainer] Add GPG to dockerfile template #1111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohsenari
approved these changes
Jun 7, 2023
| @@ -2,7 +2,7 @@ FROM debian:stable-slim | |||
|
|
|||
| # Step 1: Installing dependencies | |||
| RUN apt-get update | |||
| RUN apt-get -y install bash binutils git xz-utils wget sudo | |||
| RUN apt-get -y install bash binutils git{{if .IsDevcontainer}} gnupg2{{- end}} xz-utils wget sudo | |||
There was a problem hiding this comment.
Thanks! Makes sense, since devcontainer Dockerfile is usually used in VSCode context which signed commits are not that uncommon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change installs GPG (via the
gnupg2package) in the dev container for the purposes of GPG commit-signing.Fixes #1110
How was it tested?