Skip to content

[update] update description for update command #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

hezhizhen
Copy link
Contributor

@hezhizhen hezhizhen commented Jun 7, 2023

Summary

  1. update description for update command
  2. add copyright automatically

How was it tested?

devbox update --help
devbox global update --help

@hezhizhen hezhizhen marked this pull request as ready for review June 7, 2023 09:30
"If no packages are specified, all packages will be updated. " +
"Only updates versioned packages (e.g. `[email protected]`), not packages that are pinned to a nix channel (e.g. `python3`)",
"Only update versioned packages (e.g. `[email protected]`), not packages that are pinned to a nix channel (e.g. `python3`)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updates is a bit more accurate because it is describing what it does instead of being imperative. (the first 2 uses can be imperative so update is ok.)

Either way, this functionality is actually changing in #1107 so I'll update it there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I think it should be Only versioned packages are updated ...

@mikeland73 mikeland73 merged commit 10d38df into jetify-com:main Jun 7, 2023
@hezhizhen hezhizhen deleted the update-desc branch August 9, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants