[bugfix, cleanup] Finish moving plugin services to process compose #1150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes
services
stanza from the plugin's json definition, in favor of usingprocess-compose.yaml
.devbox services ls
, we would only return the first service defined in a plugin, and would call it the name of the plugin (instead of the name of the service). This had some downstream effects as well.<svc>-start|stop-service
. They were using the json-based definitions of the services, butdevbox service start <svc>
was using the process-compose definition, so they could diverge. Some wrappers were not being generated either, due to the bug above.Reviewers, please advise on whether this change would affect service port-forwarding.
How was it tested?
Ran
devbox services ls|start|stop|up
with different plugins installed and verified they worked as expected.Backwards-compatible?
NO, because we're removing the service wrappers (e.g.
redis-start-service
). I don't think they're being used, but @mikeland86 please confirm? If needed, I can replace them withdevbox services start redis
or something like that.