[remove nixpkgs] enable fallback for packages not in binary store #1236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savil
changed the title
savil
force-pushed
the
savil/remove-nixpkgs-3
branch
from
76f3bf1 to
60cefb4
Compare
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
savil
force-pushed
the
savil/remove-nixpkgs-3
branch
from
60cefb4 to
a70becd
Compare
|
@mikeland73 ping |
1 task
savil
commented
Jul 7, 2023
| config.allowUnfree = true; | ||
| }); | ||
| {{- end }} | ||
| {{- end }} |
There was a problem hiding this comment.
these lines are the same as in the current flake.nix:
https://github.com/jetpack-io/devbox/blob/main/internal/shellgen/tmpl/flake.nix.tmpl#L27-L34
LucilleH
approved these changes
Jul 7, 2023
yep |
savil
added a commit
that referenced
this pull request
Jul 7, 2023
## Summary builds on top of #1236 Goal: We should be able to install the package without downloading nixpkgs. Changes made to: - `nixprofile.ProfileInstall`: use `/nix/store/<hash>` as `installable` - `nixprofile.ProfileListIndex`: return index when `item.nixStorePath == pkg.PathInStore` - `devpkgs.Package.ValidateExists`: `true` if `IsInBinaryStore` - `devpkgs.Package.EnsureNixpkgsPrefetched`: skip if `IsInBinaryStore`. ## How was it tested? `devbox add [email protected]` and `devbox rm [email protected]` - [x] nixpkgs not downloaded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Many testscript unit-tests were failing because they use unversioned legacy packages like
"hello", as opposed tohello@latest, orhello@<version>.These legacy packages do not use the Binary Cache Store.
I considered whether we should treat them automatically as upgraded to
@latest, but decided against:Package.IsInBinaryStoreeasier to reason about.We should instead encourage users to
devbox updatetheir packages: which our messaging already does.The remaining three testscript unit-tests are failing due to "unable to find nix executable" errors. Will fix in followup.
How was it tested?
enabled feature-flag and ran testscripts: https://github.com/jetpack-io/devbox/actions/runs/5417704606/jobs/9848964717?pr=1236