-
Notifications
You must be signed in to change notification settings - Fork 248
fix: release for armv7l #1300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: release for armv7l #1300
Conversation
Thanks! Do you happen to know how goreleaser handles naming the binaries to distinguish the arm versions? From the docs it sounds like it might be adding a suffix. We might need to update our launcher/install script (which lives outside this repo) to handle the new filenames. I'll double check on that before merging. |
No not really - I wasn't able to test this out as stated in the PR description. |
@gcurtis I was able to run goreleaser locally and get the following output (with my latest change applied)
If we remove |
I think the install script needs to be adjusted for the arm versions but I'm not sure where to find the source. |
8ced733
to
7a50e05
Compare
I've updated the PR and Ithink we now have everything in place:
This looks like all archives are named correctly.
@gcurtis is there anything else needed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for figuring out the binary naming. This looks good to me.
Just a disclaimer (which you're probably already aware of) that Nix's support for armv7l is limited. Devbox/Nix will probably end up building most packages from source unless you set up your own binary cache. That said, let us know how it goes and thanks for the PR!
Thank you, you are right - just installing |
Summary
This should release devbox for an armv7l machine.
I've added the default values in case there was no value found here: https://goreleaser.com/customization/builds/#builds
Closes #1299
How was it tested?
Manually created a release:
TELEMETRY_KEY=whatever SENTRY_DSN=whatever EDGE_TAG=0.0.0-dev goreleaser release --clean --skip-publish --skip-announce --snapshot
unpacked the armv7l binary and ran it on my Raspberry PI.