[per-OS Packages] Error if adding --platform, when excluded_platforms
is defined
#1373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Background:
for a package,
platforms
andexcluded_platforms
should be defined mutually-exclusively.Previously, we were being "clever" by dropping "excluded_platforms" when a user
does
devbox add <package> --platform <platform>
. But I think we should:--exclude-platform
whenplatform
is defined.How was it tested?
added testscript unit-tests