Skip to content

[per-OS Packages] Error if adding --platform, when excluded_platforms is defined #1373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

savil
Copy link
Collaborator

@savil savil commented Aug 14, 2023

Summary

Background:
for a package, platforms and excluded_platforms should be defined mutually-exclusively.

Previously, we were being "clever" by dropping "excluded_platforms" when a user
does devbox add <package> --platform <platform>. But I think we should:

  1. Ensure the user explicitly makes the change to their devbox config.
  2. Be consistent with how the inverse is handled: using --exclude-platform when platform is defined.

How was it tested?

added testscript unit-tests

Copy link
Collaborator Author

savil commented Aug 14, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@savil savil requested a review from mikeland73 August 14, 2023 18:32
@savil savil merged commit 2710805 into main Aug 15, 2023
@savil savil deleted the savil/per-os-hardening branch August 15, 2023 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants