Skip to content

[per-OS Packages] Improve error message if package is uninstallable #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

savil
Copy link
Collaborator

@savil savil commented Aug 18, 2023

Summary

Instead of gating the entire per-OS packages feature due to some packages
not being installable on the user's platform for that particular version, I propose
this PR.

Here, we modify the error message to be less prescriptive. We explain the two
scenarios and let the user pick.

This is obviously not the ideal UX. But a good enough measure until we can
provide firmer guidance on which version of the package may work for this
platform?

How was it tested?

in axiom on mac, did devbox update and saw:

Ensuring packages are installed.

Installing package: gotty@latest.


Error: package gotty@latest cannot be installed on your platform x86_64-darwin.
If you know this package is incompatible with x86_64-darwin, then you could run `devbox add gotty@latest --exclude-platform x86_64-darwin` and re-try.
If you think this package should be compatible with x86_64-darwin, then it's possible this particular version is not available yet from the nix registry. You could try `devbox add` with a different version for this package.


Copy link
Collaborator Author

savil commented Aug 18, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@savil savil requested review from gcurtis and mikeland73 August 18, 2023 18:04
Copy link
Collaborator

@gcurtis gcurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good approach so the user knows what's going on.

@savil savil force-pushed the savil/update-message-for-uninstallable-package branch from 722528f to b0094af Compare August 21, 2023 18:08
@savil savil merged commit 159c801 into main Aug 21, 2023
@savil savil deleted the savil/update-message-for-uninstallable-package branch August 21, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants