Read all store paths from profile item #1417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipince
force-pushed
the
rodrigo/store-paths
branch
from
723389d to
6e40636
Compare
savil
approved these changes
Aug 23, 2023
| @@ -133,7 +133,8 @@ func ProfileListIndex(args *ProfileListIndexArgs) (int, error) { | |||
| return -1, errors.Wrapf(err, "failed to get installable for %s", args.DevPkg.String()) | |||
| } | |||
| for _, item := range items { | |||
| if pathInStore == item.nixStorePath { | |||
| if len(item.nixStorePaths) == 1 && // this should always be true | |||
| pathInStore == item.nixStorePaths[0] { | |||
There was a problem hiding this comment.
Thisshould be true, yes.
Should we assert that by erroring if len of item.nixStorePaths > 1
OR just iterate over the item.nixStorePaths so we don't mind if the assumption is violated and things keep working...
| } | ||
| nixStorePath := scanner.Text() | ||
| nixStorePaths := strings.Fields(scanner.Text()) |
There was a problem hiding this comment.
ooh TIL about strings.Fields
ipince
force-pushed
the
rodrigo/store-paths
branch
from
2f9c980 to
33692fa
Compare
ipince
force-pushed
the
rodrigo/rm-nixpkgs-profile-bug
branch
from
3b27d43 to
2ca4543
Compare
ipince
force-pushed
the
rodrigo/store-paths
branch
from
33692fa to
478b1ab
Compare
ipince
force-pushed
the
rodrigo/rm-nixpkgs-profile-bug
branch
from
2ca4543 to
2166973
Compare
ipince
force-pushed
the
rodrigo/store-paths
branch
from
478b1ab to
e53d6e1
Compare
Signed-off-by: Rodrigo Ipince <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of arbitrarily picking the first one
How was it tested?
CI tests