[dockerhub] Added action for publishing docker image #1421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucilleH
approved these changes
Aug 28, 2023
| @@ -0,0 +1,27 @@ | |||
| name: docker-image-release | |||
|
|
|||
| on: workflow_dispatch | |||
There was a problem hiding this comment.
You can test this in this PR with
on:
push:
And if it works, change it back to workflow dispatch
| uses: docker/build-push-action@v4 | ||
| with: | ||
| context: ./examples/docker/ | ||
| file: ./examples/docker/Dockerfile |
There was a problem hiding this comment.
I wonder if you can simply run devbox generate dockerfile command here, instead of pushing a hardcoded Dockerfile (so that it does not get out of sync)
There was a problem hiding this comment.
@LucilleH the output of that command is not entirely the same as the default image I want to publish.
After publishing, I'm intending to change the output of this command to use the published image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
added an action to build and publish an image containing devbox and nix installations to dockerhub
How was it tested?
Not tested yet