Skip to content

[bug fix] do not check version for devbox log, and for commands whose prefix is in the skip-list #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

savil
Copy link
Collaborator

@savil savil commented Aug 28, 2023

Summary

In the generated shellrc file, we invoke devbox log to track shell start times.

> git grep "devbox log"
internal/impl/shellrc.tmpl:devbox log shell-ready {{ .ShellStartTime }}
internal/impl/shellrc.tmpl:devbox log shell-interactive {{ .ShellStartTime }}
internal/impl/shellrc_fish.tmpl:devbox log shell-ready {{ .ShellStartTime }}
internal/impl/shellrc_fish.tmpl:devbox log shell-interactive {{ .ShellStartTime }}

We should skip checking if devbox version is up-to-date for this case.

Also, made a change to check if the commandPath matches the prefix of the commandSkipList items. This will #1420

How was it tested?

Did not test. It compiles.

@savil savil requested review from gcurtis and mohsenari August 28, 2023 22:15
@savil savil changed the title [bug fix] do not check version for devbox log [bug fix] do not check version for devbox log, and for commands whose prefix is in the skip-list Aug 28, 2023
Copy link
Collaborator

@mohsenari mohsenari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@savil savil force-pushed the savil/skip-vercheck-devbox-log branch from c7e5121 to b452548 Compare August 29, 2023 16:58
@savil savil merged commit ea64a60 into main Aug 29, 2023
@savil savil deleted the savil/skip-vercheck-devbox-log branch August 29, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants