introduce testscript-examples updater, and update the examples #1438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
ipince
approved these changes
Aug 31, 2023
|
error is because |
LucilleH
reviewed
Aug 31, 2023
| // If it is a directory, then we don't continue. | ||
| if dirEntry.IsDir() { | ||
| // Skip if it is a directory that we don't want to process at all. | ||
| skippedDirs := []string{".devbox", "node_modules"} |
There was a problem hiding this comment.
Maybe we read .gitignore? I remember a similar function in launchpad for walking with .gitignore
There was a problem hiding this comment.
yeah, that would be a good idea if we run into issues. For now, this works fairly fine, so will avoid over-engineering :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
testscripts/testrunner/updater/main.gothat walks theexamples/directory and updates projects that have a
run_testscript defined.In the future, perhaps we want this to run on other (non run_test) projects as
well, but that is left as an exercise for future contributors.
Also includes a fix for
devbox updatefor insecure packages.How was it tested?
Note: this adds info to devbox.lock for the Remove Nixpkgs feature that
is not turned on. However, things should continue to work.