[rm nixpkgs] enable feature flag (assuming tests pass) #1443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
|
Let me know when this is ready for review. Not sure if I'm blocking you here (I think I'm not). |
savil
force-pushed
the
savil/enable-rm-nixpkgs
branch
from
95b7b87 to
5804729
Compare
|
@ipince I rebased. Should be ready for review now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We can now update all the examples, and run the tests!
Assuming this passes, I think we can enable the feature. Still feel it should not go in this week's release, but in the next one so we can dog food it internally.
How was it tested?
ran
devbox run update-examples.testscripts should pass