Skip to content

improve documentation #1451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 7, 2023
Merged

Conversation

pinage404
Copy link
Contributor

Summary

I just discovered DevBox

I read the whole documentation

I found some errors

I did a big PR with anrelated content, if you disagree with some of the commits, i can split in several PR

How was it tested?

It's just markdown content, i haven't tested it

Copy link
Collaborator

@LucilleH LucilleH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

* nodejs_19 (19.9.0)
* nodejs_20 (20.0.0)
...
$ devbox search python
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lagoja did you intend to include the nodejs results before, or was it supposed to be python?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be nodejs for this example, since the results look cleaner

Signed-off-by: John Lago <[email protected]>
@Lagoja
Copy link
Contributor

Lagoja commented Sep 7, 2023

Awesome, looks good to land! Thanks again @pinage404!

@Lagoja Lagoja merged commit b939c5d into jetify-com:main Sep 7, 2023
@pinage404 pinage404 deleted the improve_documentation branch September 7, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants