Skip to content

[profile remove] if package was not found, change message from error to info #1458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

savil
Copy link
Collaborator

@savil savil commented Sep 7, 2023

Summary

When trying to remove a package, or update a package, we'd print a message
like below if the package was not found in the profile.

Error: Package uxn@latest not found in profile. Skipping.

This is confusing for a few reasons:

  1. Devbox users are not usually aware of a concept called "profile". This is a nix-ism that is seeping through our messaging.
  2. Even if they understand "nix profile", there's nothing actionable about this message. Their package is still removed from devbox.json and the shell environment (which is what they care about).

Instead, we can make this a debug.Log, and not bother users with it.

How was it tested?

didn't explicitly test. Compiles.

Copy link
Collaborator Author

savil commented Sep 7, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@savil savil requested a review from ipince September 7, 2023 18:16
@savil savil merged commit 68a9b9b into main Sep 7, 2023
@savil savil deleted the savil/profile-rm-package-not-found-msg branch September 7, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants