Skip to content

[rm-nixpkgs] drop warning about missing store path when updating lockfile #1459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

savil
Copy link
Collaborator

@savil savil commented Sep 7, 2023

Summary

We'd show this warning about missing store path to users.

❯ time devbox add nodePackages_latest.yalc@latest
Warning: Failed to resolve store path for x86_64-darwin with storeHash h1fpdwwq2x528xwq3si97z6vny0vkjhf. Installing will be a bit slower.
Warning: Failed to resolve store path for x86_64-linux with storeHash is1ds4h8qa95s31crvgf19mlmx1990s3. Installing will be a bit slower.
Warning: Warning: Failed to resolve store path for aarch64-linux with storeHash cqjb45zk4cs4i4qzkknh5116zk7z471g. Installing will be a bit slower.
Failed to resolve store path for aarch64-darwin with storeHash 5wfxcx235xpwr5lcv29ijlpw85kb0vj0. Installing will be a bit slower.

Installing package: nodePackages_latest.yalc@latest.

[1/1] nodePackages_latest.yalc@latest
[1/1] nodePackages_latest.yalc@latest: Success
devbox add nodePackages_latest.yalc@latest  2.00s user 0.66s system 47% cpu 5.551 total

However, this isn't very helpful:

  1. The users cannot do anything with this info.
  2. The install experience will be the "slow path" but that is what users are already used to.
  3. If a user complains about slow install, then we can inspect their devbox.lock and we'll know if the store-path is missing or not.

How was it tested?

> time devbox add nodePackages_latest.yalc@latest

Installing package: nodePackages_latest.yalc@latest.

[1/1] nodePackages_latest.yalc@latest
[1/1] nodePackages_latest.yalc@latest: Success

________________________________________________________
Executed in   12.67 secs    fish           external
   usr time    4.75 secs    0.99 millis    4.75 secs
   sys time    1.72 secs    1.83 millis    1.72 secs

Copy link
Collaborator Author

savil commented Sep 7, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@savil savil requested review from gcurtis and ipince September 7, 2023 18:34
@savil savil merged commit 96a193e into main Sep 7, 2023
@savil savil deleted the savil/remove-warning-missing-store-path branch September 7, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants