Skip to content

[auth] Use new auth package #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 19, 2023
Merged

[auth] Use new auth package #1492

merged 2 commits into from
Sep 19, 2023

Conversation

mikeland73
Copy link
Contributor

Summary

Migrate to new auth package. The feature on devbox that used previous auth was not publicized and there's no data on S3 that we need to migrate.

How was it tested?

devbox auth login
devbox auth whoami

loreto
loreto approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@loreto loreto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikeland73 mikeland73 merged commit fbdbf01 into main Sep 19, 2023
@mikeland73 mikeland73 deleted the landau/new-auth branch September 19, 2023 16:44
@sentry-io
Copy link

sentry-io bot commented Sep 28, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ **Generic Error: <redacted errors.withStack>: <redacted errors.errorString> go.jetpack.io/devbox/internal/boxcli in pullCmd... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loreto loreto loreto approved these changes

@LucilleH LucilleH Awaiting requested review from LucilleH

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeland73 @loreto