[script-exit-on-error] disable for init-hooks #1493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
mikeland73
approved these changes
Sep 20, 2023
Comment on lines
+103
to
+105
| // NOTE: Devbox scripts will run using `sh` for consistency. | ||
| // However, we need to disable this for `fish` shell if/when we allow this for init_hooks, | ||
| // since init_hooks run in the host shell, and not `sh`. |
There was a problem hiding this comment.
I don't think we'll never be able to add this to init hooks unless we decide not to source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@Lagoja identified an issue with scripts-exit-on-error. We source init-hooks into the host shell. So,
set -ewill get set in the host shell. Any subsequent error will cause the shell to exit (error may be from the init-hook, or later in the shell).For now, this PR disables this feature entirely for init hooks. We'll revisit this later: #1494
Also, this PR undoes the previous change to restrict this feature to fish-shells, since that only applied to init-hooks. Regular Devbox scripts always run in
sh.How was it tested?
testscript unit-tests
did a sanity check that regular init_hooks work.