[envsec] Use runx to install envsec #1497
Conversation
| // temporary, mac only | ||
| home, _ := os.UserHomeDir() | ||
| path := filepath.Join(home, "Library/Caches/jetpack.io/pkgs/jetpack-io/envsec/v0.0.1/darwin/arm64/") | ||
| os.Setenv("PATH", path+string(os.PathListSeparator)+os.Getenv("PATH")) |
There was a problem hiding this comment.
Does runx not handle macOS?
There was a problem hiding this comment.
This is for testing. The runx library will now return the path (for all os's)
| func Env(projectDir string) (map[string]string, error) { | ||
|
|
||
| defer debug.FunctionTimer().End() | ||
|
|
||
| if envCache != nil { |
There was a problem hiding this comment.
How do you validate/invalidate this cache
There was a problem hiding this comment.
It never gets invalidated, it's lifetime is just the command. So if you do devbox run you only fetch it once.
Later on I think we can look into refreshing env vars for long running shells, but even then this cache is OK.
| } | ||
|
|
||
| func ensureEnvsecInstalled() error { | ||
| // In newer runx version this will return the paths | ||
| paths, err := runx.Install("jetpack-io/[email protected]") |
There was a problem hiding this comment.
Should we not pin this? Or pinning is necessary?
There was a problem hiding this comment.
I'll unpin it for now, but if we want to keep it unpinned that means we can't make backward incompatible changes to envsec.
Summary
Mostly for testing. Need to merge a few runx changes to finish this PR.
How was it tested?