Skip to content

[envsec] Add envsec to path if used in config #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

mikeland73
Copy link
Contributor

Summary

This PR adds envsec to devbox env $PATH if it is used in config. This allows user to use envsec without explicitly installing it and without adding any envsec specific commands to devbox. e.g.

devbox run envsec ls

and devbox shell followed by envsec ls

will both work.

Other improvements:

  • Don't modify current process path when adding envsec (it's best to avoid os.Setenv if we can so that environment is more consistent trough run and now longer depends on when envsec.EnsureInstalled is called.)
  • Remove feature flag (this feature is gated anyway by requiring explicit opt-in in the config)

How was it tested?

devbox run envsec ls

@mikeland73 mikeland73 merged commit bc9de75 into main Sep 27, 2023
@mikeland73 mikeland73 deleted the landau/add-envsec-to-path branch September 27, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants