impl: set SHELL environment variable #1512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were assuming that most shells set `SHELL` upon startup, but this is only true for bash. Usually `SHELL` is only set by `login`, so we need to set it ourselves when launching the user's shell. Also remove the `keyEqualsValue` which was only being used by the VSCode integration. This function escapes environment variable values for a shell, but we were setting the `code` process's environment with them directly. This was mangling the values by adding quotes and backslashes. Fixes #1454.
mohsenari
approved these changes
Sep 29, 2023
|
@mohsenari thanks for confirming. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were assuming that most shells set
SHELLupon startup, but this is only true for bash. UsuallySHELLis only set bylogin, so we need to set it ourselves when launching the user's shell.Also remove the
keyEqualsValuewhich was only being used by the VSCode integration. This function escapes environment variable values for a shell, but we were setting thecodeprocess's environment with them directly. This was mangling the values by adding quotes and backslashes.Fixes #1454.