all: (mostly) automated clean up #1513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeland73
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
Add gofumpt here script here. Then we can add CICD that runs it and errors out if there are any changes.
There was a problem hiding this comment.
Added a devbox run fmt script that runs in the lint job right before golangci-lint. If CI is set, it prints any unformatted files and exits with an error. When CI isn't set, it silently formats the files.
|
Tests fails just look like timeouts. Probably the dependency changes caused longer build times. |
gcurtis
force-pushed
the
gcurtis/cleanup
branch
from
6dabdf2 to
f90be11
Compare
- Unset any user-defined Go environment variables `devbox.json` to make
builds more reproducible. Clean up some of the build scripts.
- Remove `exp/slices` and `exp/maps` now that they're in the Go 1.21
stdlib.
- Run `find . -name '*.go' -exec gofumpt -extra -w {} \+` to format Go
files.
- Add a `devbox run fmt` script and run it in CI.
- Upgrade dependencies that don't have any backwards incompatible
changes.
- Organize direct vs. indirect modules and run `go mod tidy`.
gcurtis
force-pushed
the
gcurtis/cleanup
branch
from
f90be11 to
e0bd751
Compare
gcurtis
force-pushed
the
gcurtis/cleanup
branch
from
a105b92 to
2d93906
Compare
|
Merging because the CI error was due to a GitHub API rate limit (presumably due to force-pushing debug commits). |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devbox.jsonto make builds more reproducible. Clean up some of the build scripts.exp/slicesandexp/mapsnow that they're in the Go 1.21 stdlib.find . -name '*.go' -exec gofumpt -extra -w {} \+to format Go files.go mod tidy.