[UX] print statement for recomputing the nixEnv #1521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
mikeland73
approved these changes
Oct 3, 2023
Lagoja
pushed a commit
that referenced
this pull request
Oct 3, 2023
## Summary This print-dev-env calculation may be a bit slow, so we should print a statement for the waiting user. I do this in `ensurePackagesAreInstalled`, instead of in `nix.PrintDevEnv` because otherwise we can print it 3x due to our cache misses. Note, this PR is focussed on the least-risky change for the release to improve UX for improved wait times on switching to Remove Nixpkgs mode. ## How was it tested? compiles (cherry picked from commit e008f3b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This print-dev-env calculation may be a bit slow, so we should print a statement
for the waiting user.
I do this in
ensurePackagesAreInstalled, instead of innix.PrintDevEnvbecause otherwise we can print it 3x due to our cache misses.Note, this PR is focussed on the least-risky change for the release to improve UX for improved wait times on switching to Remove Nixpkgs mode.
How was it tested?
compiles